aeubanks added a comment.

In D145403#4175178 <https://reviews.llvm.org/D145403#4175178>, @tejohnson wrote:

> In D145403#4172268 <https://reviews.llvm.org/D145403#4172268>, @aeubanks 
> wrote:
>
>> still need to update tests and make sure this doesn't regress anything, but 
>> sending out to make sure that this makes sense to you
>
> In theory this makes sense, certainly per the comment there. Did you see any 
> surprising test changes?

no, just pipeline tests. I think this is good to go. I ran some benchmarks and 
didn't see any regressions, but I'll run them one more time before submitting


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145403/new/

https://reviews.llvm.org/D145403

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to