tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land.
lgtm ================ Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:957 + // pipeline already cleaned up the frontend output. + if (Phase != ThinOrFullLTOPhase::ThinLTOPostLink) { + // Do basic inference of function attributes from known properties of system ---------------- I am reminded when reviewing this change that this method assumes it is not called during the FullLTOPostLink phase. Which it isn't today, but can you add an assert at the top of this function that the Phase is not FullLTOPostLink since all the checking here would break down if anything changed that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145403/new/ https://reviews.llvm.org/D145403 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits