aaron.ballman added a comment. FWIW, I'm also nervous about this change. Keeping the file handle open changes the ways in which you can access the file from other processes (or within the same process), so I'd expect this to cause some heartache, possibly for downstreams as well as Clang users. I mostly worry about things like leaving a file open interacting with things like deleting the file from the file system, including via a user interaction.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146490/new/ https://reviews.llvm.org/D146490 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
