kadircet added a comment.

In D146490#4209495 <https://reviews.llvm.org/D146490#4209495>, @aganea wrote:

> Fair enough. There are several choices forward: either we mark the issue as 
> "Will Not Fix" or I can try only scoping this patch to only keep the handle 
> open for network drives/paths. Any other suggestions?

I am afraid that a solution that keeps file handles alive indefinitely won't 
work even for that narrow set of users (unless they're operating on a read-only 
FS). so another alternative could be to have a different definition for 
uniqueids on these specific cases, e.g. use filepaths (canonicalized for 
capitalization & symlinks & hardlinks etc.). it might be slower than how things 
are working today, but i guess if that's needed for correctness in certain 
platforms one has to eat that regression?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146490/new/

https://reviews.llvm.org/D146490

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to