zahiraam added inline comments.
================ Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:662-665 +def err_type_definition_cannot_be_modified : Error< + "%0 type definition cannot be modified inside a scope containing " + "'#pragma clang fp eval_method(%1)' when a command line " + "option 'ffp-eval-method=%2' is used">; ---------------- aaron.ballman wrote: > I think we should add some documentation as to why this error happens. > Naively, users expect the pragma to override the command line (the command > line is the "default" and the pragma overrides that in the cases the default > is wrong), so I'd imagine a user getting this error would ask, "But why?" Where do you suggest I add the documentation? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
