rjmccall added a comment. Okay, so modifying `math.h` to use this attribute is acceptable? That's great, that's definitely the best outcome for the compiler.
Just a minor request about the diagnostic name, but otherwise LGTM. ================ Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11503 + +def err_type_definition_cannot_be_modified : Error< + "cannot use type '%0' within '#pragma clang fp eval_method'; type is set " ---------------- CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
