hubert.reinterpretcast added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:714-716
+    if (!Args.hasFlag(options::OPT_fdata_sections,
+                      options::OPT_fno_data_sections, UseSeparateSections) &&
+        Args.hasArg(options::OPT_fno_data_sections))
----------------
I think this (undesirably) generates an error even `-mno-roptr` is in effect.

This logic seems otherwise convoluted. I think the main logic should only care 
that `data-sections` is off. We can separately assert that `data-sections` is 
on by default on AIX.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144190/new/

https://reviews.llvm.org/D144190

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to