hubert.reinterpretcast added inline comments.
================ Comment at: clang/docs/ReleaseNotes.rst:317 + ``-fno-data-sections``. When ``-mxcoff-roptr`` is in effect at link time, + read-only data sections with relocatable address values that resolve to + imported symbols are made writable. ---------------- Two spaces => one space ================ Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:718-721 + // On AIX, data_sections is on by default. We only need to check + // if data_sections is explicitly turned off. + if (Args.hasArg(options::OPT_fno_data_sections)) + D.Diag(diag::err_roptr_requires_data_sections); ---------------- Should use `hasFlag` to check if data_sections is off. As background: The logic near line 699 says to add `-data-sections=1` if data_sections is on and, if data_sections is off, only add `-data-sections=0` if `-fno-data-sections` was explicitly present. This allows the LTO default for data_sections to be a separate policy from the non-LTO default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
