carlosgalvezp added inline comments.
================
Comment at:
clang-tools-extra/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp:55
+ AvoidByValueCaptureDefaultWhenCapturingThisCheck>(
+
"cppcoreguidelines-avoid-by-value-capture-default-when-capturing-this");
CheckFactories.registerCheck<AvoidCapturingLambdaCoroutinesCheck>(
----------------
PiotrZSL wrote:
> carlosgalvezp wrote:
> > PiotrZSL wrote:
> > > PiotrZSL wrote:
> > > > this name is hard to understand
> > > >
> > > > I asked ChatGPT about it, and here are some other proposals:
> > > >
> > > > - cppcoreguidelines-avoid-by-value-default-this-capture
> > > > - cppcoreguidelines-avoid-this-capture-by-value-default
> > > > - cppcoreguidelines-explicit-this-capture-by-value
> > > > - cppcoreguidelines-implicit-this-capture-by-value
> > > > - cppcoreguidelines-implicit-by-value-this-capture
> > > > - cppcoreguidelines-prefer-explicit-this-capture
> > > > - cppcoreguidelines-avoid-ambiguous-this-capture
> > > Probably something like this would be good:
> > > cppcoreguidelines-avoid-implicit-this-capture-by-value
> > Nice suggestions! I've done a bit of mix of them, let me know if you are
> > happy with it.
> To be honest that "default" sounds strange. Simply I check name does not read
> as an "sentence", more as bunch of words, but I'm fine with this.
I agree, I'm not very happy either. We had quite a lot of discussion in the
original patch about this. The problem is that the Standard calls it "capture
default" which doesn't read like an English sentence (should be "default
capture"). But it seems "capture default" is a widely used term out there and
in the repo, so that's why we went for that.
What about the following?
- cppcoreguidelines-ambiguous-capture-default-by-value
- cppcoreguidelines-ambiguous-by-value-capture-default
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148340/new/
https://reviews.llvm.org/D148340
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
