Fznamznon added inline comments.
================ Comment at: clang/lib/AST/ASTImporter.cpp:7033-7036 + if (E->isExprPredicate()) + ToControllingExpr = importChecked(Err, E->getControllingExpr()); + else + ToControllingType = importChecked(Err, E->getControllingType()); ---------------- Just a NIT: would something like ``` ToControllingExpr = importChecked(Err, E->isExprPredicate()? E->getControllingExpr() : E->getControllingType()); ``` look a bit more elegant (when also formatted properly)? ================ Comment at: clang/lib/Parse/ParseExpr.cpp:3308 + return ExprError(); + } else { + const auto *LIT = cast<LocInfoType>(ControllingType.get().get()); ---------------- No `else` after return? ================ Comment at: clang/lib/Parse/ParseTentative.cpp:645 isAmbiguous = true; - + // We are supopsed to be inside the first operand to a _Generic selection + // expression, so if we find a comma after the declarator, we've found a ---------------- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149904/new/ https://reviews.llvm.org/D149904 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits