shafik added a comment.

In D150226#4336755 <https://reviews.llvm.org/D150226#4336755>, @rupprecht wrote:

> We're still using `-Wno-enum-constexpr-conversion`, although I'm not sure if 
> we need that or if we just forgot to remove it after doing some cleanup. I'm 
> trying it out now. (Sorry, I'm not sure we were aware that having a way to 
> turn this off was just temporary).

Please let me know how things look on your end.

> BTW, LLVM itself still uses this flag in openmp: 
> https://github.com/llvm/llvm-project/blob/c2ce2a509f74a85a3c0ef4b9d6d79fbacc7e8bdf/openmp/cmake/HandleOpenMPOptions.cmake#L34

Thank you for flagging that.

I followed up on the PR that put in this change to see if they can remediate 
this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150226/new/

https://reviews.llvm.org/D150226

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to