hiraditya added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:424
+ if (Triple.isAndroid()) {
+ // AArch64 has frame pointers enabled for non-leaf functions.
+ switch (Triple.getArch()) {
----------------
enh wrote:
> (where? is it simpler to just add arm64 to the switch?)
yeah we can add it for better readability but it would be redundant.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:530
+ Triple.isAArch64() || Triple.isPS() || Triple.isVE() ||
+ (Triple.isAndroid() && (Triple.getArch() ==
llvm::Triple::riscv64)));
if (NoOmitFP || mustUseNonLeafFramePointerForTarget(Triple) ||
----------------
enh wrote:
> how does this work for Android/arm64?
becaues of `Triple.isAArch64()`, AArch64 always has non-leaf frame pointers for
all platforms.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150490/new/
https://reviews.llvm.org/D150490
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
