enh accepted this revision. enh added a comment. This revision is now accepted and ready to land.
(lgtm with craig.topper's suggested simplification.) ================ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:530 + Triple.isAArch64() || Triple.isPS() || Triple.isVE() || + (Triple.isAndroid() && (Triple.getArch() == llvm::Triple::riscv64))); if (NoOmitFP || mustUseNonLeafFramePointerForTarget(Triple) || ---------------- hiraditya wrote: > enh wrote: > > how does this work for Android/arm64? > becaues of `Triple.isAArch64()`, AArch64 always has non-leaf frame pointers > for all platforms. lol. i could seem so much smarter if only i'd learn to read :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150490/new/ https://reviews.llvm.org/D150490 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
