vikramRH added inline comments.
================ Comment at: llvm/lib/Transforms/Utils/AMDGPUEmitPrintf.cpp:426-427 + + // The buffered version still follows OpenCL printf standards for + // printf return value, i.e 0 on success, 1 on failure. + ConstantPointerNull *zeroIntPtr = ---------------- sameerds wrote: > So we cannot use a buffered printf in HIP? I guess hostcall version returns number of bytes printed as the printf return value, This is not done in Buffered case since we do not print stuff in "real time", instead I have decided to stick with OpenCL standard (return 0 on success and -1 on failure) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150427/new/ https://reviews.llvm.org/D150427 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
