vikramRH added inline comments.
================ Comment at: llvm/lib/Transforms/Utils/AMDGPUEmitPrintf.cpp:458 + auto CreateControlDWord = M->getOrInsertFunction( + StringRef("__ockl_create_control_dword"), Builder.getInt32Ty(), + Builder.getInt32Ty(), Int1Ty, Int1Ty); ---------------- arsenm wrote: > vikramRH wrote: > > arsenm wrote: > > > Do we really need another ockl control variable for this? Why isn't it a > > > parameter? printf=stdout always > > There are certain HIP API's such as "hip_assert" that output to stderr. > > currently such API's are supported via hostcalls. Although this > > implementation does not currently support the API's ,its kept as an option. > Right but the way to handle that would be a parameter for where to output, > not an externally set global I am not clear here, you expect additional inputs to device lib function ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150427/new/ https://reviews.llvm.org/D150427 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits