beanz added inline comments.
================
Comment at: clang/test/ParserHLSL/group_shared.hlsl:14
-// expected-error@+1 {{expected expression}}
float groupshared [[]] i = 12;
----------------
aaron.ballman wrote:
> philnik wrote:
> > Should this also get an extension warning/should attributes be disabled for
> > HLSL?
> CC @beanz
>
> I was wondering the same thing. :-)
By bug rather than design DXC allows C++ attribute syntax in some places for
HLSL.
I'm totally fine with (and prefer) following the rest of the languages here and
having HLSL in Clang always allow C++ attributes regardless of language version.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151683/new/
https://reviews.llvm.org/D151683
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
