philnik added inline comments.
================
Comment at: clang/test/Parser/cxx-decl.cpp:316
#if __cplusplus >= 201103L
-// expected-error@+3 {{expected}}
+// expected-error@+2 {{expected}}
// expected-error@-3 {{expected ';' after top level declarator}}
----------------
aaron.ballman wrote:
> Huh... I wasn't expecting to see a change here because there's no attribute
> nearby. Probably fine, but still a bit curious.
This is probably because of the whitespace trim below.
================
Comment at: clang/test/ParserHLSL/group_shared.hlsl:14
-// expected-error@+1 {{expected expression}}
float groupshared [[]] i = 12;
----------------
beanz wrote:
> aaron.ballman wrote:
> > philnik wrote:
> > > Should this also get an extension warning/should attributes be disabled
> > > for HLSL?
> > CC @beanz
> >
> > I was wondering the same thing. :-)
> By bug rather than design DXC allows C++ attribute syntax in some places for
> HLSL.
>
> I'm totally fine with (and prefer) following the rest of the languages here
> and having HLSL in Clang always allow C++ attributes regardless of language
> version.
Would you like some sort of warning?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151683/new/
https://reviews.llvm.org/D151683
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
