yaxunl added inline comments.
================
Comment at: clang/lib/CodeGen/CGCall.cpp:2052-2106
+void clang::CodeGen::mergeDefaultFunctionDefinitionAttributes(
+ llvm::Function &F, const CodeGenOptions CodeGenOpts,
+ const LangOptions &LangOpts, const TargetOptions &TargetOpts,
+ bool WillInternalize) {
+
+ llvm::AttrBuilder FuncAttrs(F.getContext());
+ if (!TargetOpts.CPU.empty())
----------------
can we reorder these functions to minimize the diffs? Also some comments about
the difference among these functions may help.
================
Comment at: clang/lib/CodeGen/CodeGenAction.cpp:266
// Links each entry in LinkModules into our module. Returns true on error.
- bool LinkInModules() {
+ bool LinkInModules(llvm::Module *M = nullptr) {
for (auto &LM : LinkModules) {
----------------
Removing the default argument may make the code clearer
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152391/new/
https://reviews.llvm.org/D152391
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
