JonChesterfield added inline comments.
================
Comment at: clang/lib/CodeGen/CGCall.cpp:2001
-void CodeGenModule::getDefaultFunctionAttributes(StringRef Name,
- bool HasOptnone,
- bool AttrOnCallSite,
- llvm::AttrBuilder &FuncAttrs)
{
- getTrivialDefaultFunctionAttributes(Name, HasOptnone, AttrOnCallSite,
- FuncAttrs);
- if (!AttrOnCallSite) {
- // If we're just getting the default, get the default values for mergeable
- // attributes.
- addMergableDefaultFunctionAttributes(CodeGenOpts, FuncAttrs);
- }
-}
+/// Adds attributes to \p F according to our \p CodeGenOpts and \p LangOpts, as
+/// though we had emitted it ourselves. We remove any attributes on F that
----------------
I'm used to this sort of copy-some-args-and-not-others showing up in bug
reports. Could this patch be re-ordered to make it apparent what functional
changes are happening relative to the current head?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152391/new/
https://reviews.llvm.org/D152391
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
