skan added inline comments.
================ Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:1895 + if (RelocatedSection != Obj.section_end() && Name.contains(".dwo")) { + // Each section in COFF can directly contain relocations. + if (isa<COFFObjectFile>(&Obj) && Section.relocations().empty()) ---------------- The comment is confusing according to line 1900. Could you refine it? ================ Comment at: llvm/test/DebugInfo/COFF/dwarf-headers.ll:75 +!14 = !{i32 1, !"MaxTLSAlign", i32 65536} +!15 = !{!"clang version 17.0.0 (https://github.com/llvm/llvm-project.git f1106ef6c9d14d5b516ec352279aeee8f9d12818)"} ---------------- Simplify it to "clang"? ================ Comment at: llvm/test/DebugInfo/COFF/fission-cu.ll:19 +!3 = !DIBasicType(name: "int", size: 32, align: 32, encoding: DW_ATE_signed) +!4 = distinct !DICompileUnit(language: DW_LANG_C99, file: !2, producer: "clang version 3.3 (trunk 169021) (llvm/trunk 169020)", isOptimized: false, runtimeVersion: 0, splitDebugFilename: "baz.dwo", emissionKind: FullDebug, enums: !5, retainedTypes: !5, globals: !6, imports: !5) +!5 = !{} ---------------- Simplify the producer to "clang"? ================ Comment at: llvm/test/DebugInfo/COFF/fission-cu.ll:118 +; HDR-NOT: .debug_aranges +; HDR-NOT: .rela.{{.*}}.dwo + ---------------- Why do we check .rela* section? It's linux relocation section name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits