skan added inline comments.
================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:1896
+ // Each section in COFF can directly contain relocations.
+ if (isa<COFFObjectFile>(&Obj) && Section.relocations().empty())
+ continue;
----------------
Should we merge the check into line 1894?
================
Comment at: llvm/test/DebugInfo/COFF/fission-sections.ll:19
+!3 = !DIBasicType(name: "int", size: 32, align: 32, encoding: DW_ATE_signed)
+!4 = distinct !DICompileUnit(language: DW_LANG_C99, file: !2, producer: "clang
version 3.3 (trunk 169021) (llvm/trunk 169020)", isOptimized: false,
runtimeVersion: 0, splitDebugFilename: "baz.dwo", emissionKind: FullDebug,
enums: !5, retainedTypes: !5, globals: !6, imports: !5)
+!5 = !{}
----------------
ditto
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152785/new/
https://reviews.llvm.org/D152785
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
