MaskRay added a comment.

The code change looks good but the driver test will cause an issue.
I think we need a fake sysroot tree under `Inputs/`.
Otherwise if we have a system cross gcc at 
`/usr/lib/gcc{,-cross}/powerpc64le-unknown-eabi/12`, Clang Driver will pick up 
these files.
This is really difficult to debug for someone not so familiar with Driver (I 
think I have done quite a lot of work, but still quite puzzled).
You may check many other tests using --sysroot, remove --sysroot, and check the 
behavior change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154357/new/

https://reviews.llvm.org/D154357

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to