MaskRay added a comment. In D154357#4496247 <https://reviews.llvm.org/D154357#4496247>, @cwalther wrote:
> That summary wasn’t intended to be a commit message at all, but a description > of the problem and start of the discussion. My commit message was part of the > uploaded patch (since I generated it using `git show`) and said > >> [Driver] Recognize powerpc-*-unknown-eabi as a bare-metal toolchain >> >> Calling GCC as the linker as the Generic_ELF toolchain does is >> inappropriate for an all-LLVM embedded toolchain. > > but it looks like Phabricator doesn’t show that anywhere. > > I haven’t user Phabricator before, so to make sure I am understanding you > correctly: You want me to edit the “summary” on this page, and then when you > commit the patch, it will automatically use that as the commit message? That > still seems much too verbose for a commit message to me even after removing > that last paragraph, but if you prefer that to the terse message above, > that’s fine with me. Yes, edit the summary. You have done that. Thanks! If you have write access to the llvm-project repository, you may adjust commit message before committing. If you don't and ask someone else to land the patch for you, they may use `arc diff D154357` to fetch the patch, whose commit message will contain the Differential summary. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154357/new/ https://reviews.llvm.org/D154357 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
