MaskRay added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7226
+ } else {
+ Args.claimAllArgs(options::OPT_fhip_uniform_block,
+ options::OPT_fno_hip_uniform_block);
----------------
yaxunl wrote:
> MaskRay wrote:
> > Why is the -Wunused-command-line-argument warning suppressed in non-IsHIP
> > mode?
> Users may want to add these options to clang config file.
>
> Is there a general rule which options should be claimed?
Options in a configuration file are automatically claimed.
I don't know a general rule, but we generally don't claim newly introduced
options.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155213/new/
https://reviews.llvm.org/D155213
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
