MaskRay added inline comments.
================ Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:773 + # Disabling this GCC warning as it is emitting a lot of false positives + append_if(CMAKE_COMPILER_IS_GNUCXX "-Wno-nonnull" CMAKE_CXX_FLAGS) ---------------- Use an imperative sentence, i.e. `Disable ... ` and append a full stop. `CMAKE_COMPILER_IS_GNUCXX` is deprecated . Use `CMAKE_<LANG>_COMPILER_ID` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155857/new/ https://reviews.llvm.org/D155857 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
