steven_wu added inline comments.
================ Comment at: llvm/lib/TargetParser/LoongArchTargetParser.cpp:19 +StringRef Arch; +StringRef TuneCPU; ---------------- Why do we store `Arch` and `TuneCPU` as globals? We should not have as little global state in compiler as possible. Any reason why they are not stored in `LoongArchTargetInfo` instead like other Targets? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155824/new/ https://reviews.llvm.org/D155824 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
