SixWeining added a comment.

In D155824#4548677 <https://reviews.llvm.org/D155824#4548677>, @steven_wu wrote:

> After another look, I will need to request to revert this because this 
> implementation doesn't work with `-fno-integrated-cc1` at all. You can't 
> setCPU/Tune in the driver into a global variable and expect that will work 
> during compilation.
>
> You can reproduce with `-fno-integrated-cc1` option or build clang with cmake 
> option `-DCLANG_SPAWN_CC1=On`.

Thanks. I’ll investigate as soon as possible. BTW, did it break any buildbot?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155824/new/

https://reviews.llvm.org/D155824

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to