ilya-biryukov requested changes to this revision. ilya-biryukov added a comment. This revision now requires changes to proceed.
Hi @ChuanqiXu, Sam is on vacation now, but we are in the same team and I am responding on behalf of the team. First, sorry for not getting to this review earlier. The change is quite big, and, as Sam mentioned, we want to make sure this scales to our (unreasonable) project sizes and supports for header modules. That is to say, we feel that the stakes are high for getting it right. In order to move forward with this change, we need to do some homework to figure out the longer-term strategy for modules in Clangd. We plan to come back with answers, but it may take a few months because planning this urgently is tough. I do want to stress that we want to get modules in Clangd right, plan to work on it. Sorry for these delays and confusion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153114/new/ https://reviews.llvm.org/D153114 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
