benlangmuir wrote:

Thanks for laying it out. I also find this easier to understand in your latest 
changes because the comments in `isBeforeInTranslationUnit` lay out the 
intended ordering without relying on `isInTheSameTranslationUnit` returning 
`false` for builtin buffers, which is the part that seemed suspect.

https://github.com/llvm/llvm-project/pull/66962
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to