sam-mccall wrote: Ripping out this feature sounds great, as does fixing the non-translation of builtin buffer locations.
My only concern is that this will make isBeforeInTranslationUnit more expensive. A loc being in one of these special "<buffers>" is the rare case, and the code recognizing them doesn't look fast (which didn't previously matter, as we only reached it rarely). That said, isBeforeInTranslationUnit is slow already, and I don't think it's hot in clang, moreso in tools like clang-tidy whose performance is less-critical. So let's make it right, and then optimize it again if problems arise. https://github.com/llvm/llvm-project/pull/66962 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
