zaks.anna added inline comments.
================
Comment at: test/Analysis/copypaste/functions.cpp:7
@@ -6,3 +6,3 @@
-int max(int a, int b) { // expected-warning{{Detected code clone.}}
+int max(int a, int b) { // expected-warning{{Clone of this code was detected}}
log();
----------------
"was" -> "is"?
Do we use past or present elsewhere?
================
Comment at: test/Analysis/copypaste/suspicious-clones.cpp:61
@@ -60,3 +60,3 @@
b /= a + b;
- c -= b * a; // expected-warning{{suspicious code clone detected; did you
mean to use 'a'?}}
+ c -= b * a; // expected-warning{{Suspicious code clone detected; did you
mean to use 'a'?}}
return c;
----------------
The error message seems too verbose and focused on the implementation rather
than user (ex: "suspicious code clone" and "suggestion is based").
Maybe we could say something like this:
- Did you mean to use 'a'?
- Similar code snippet here
https://reviews.llvm.org/D24916
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
