zaks.anna added inline comments. ================ Comment at: test/Analysis/copypaste/suspicious-clones.cpp:61 @@ -60,3 +60,3 @@ b /= a + b; - c -= b * a; // expected-warning{{suspicious code clone detected; did you mean to use 'a'?}} + c -= b * a; // expected-warning{{Suspicious code clone detected; did you mean to use 'a'?}} return c; ---------------- zaks.anna wrote: > zaks.anna wrote: > > zaks.anna wrote: > > > The error message seems too verbose and focused on the implementation > > > rather than user (ex: "suspicious code clone" and "suggestion is based"). > > > > > > Maybe we could say something like this: > > > > > > - Did you mean to use 'a'? > > > - Similar code snippet here > > > > > > > > Better: > > > > Did you mean to use 'a'? > > Similar code snippet here uses 'b' > > > > Did you mean to use 'a' instead of 'b'? > > Similar code snippet here > Another refinement > > Potential copy-paste error: did you mean to use 'a' instead of 'b'? > Similar code here Potential copy-paste error; did you really mean to use 'b' here? Similar code using 'a' here Similar code using 'c' here
https://reviews.llvm.org/D24916 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits