erichkeane added a comment.
In D134475#4655362 <https://reviews.llvm.org/D134475#4655362>, @RIscRIpt wrote:
> Should I re-submit it to GitHub?
While I hate that we'll lose all of the Phabriator history on this one, I don't
see being able to complete this review in the next two weeks before Phab closes
down. The C++ Standards meeting is in 2 weeks, which makes it particularly
difficult.
If you can properly rebase, submit this to github, and include a summary of the
Phab discussion in a way that easy enough to catch back up on, I'll do a deep
dive into this in the next week or 3.
Sorry for the delay, this fell off my radar somehow.
================
Comment at: clang/test/SemaCXX/ms-constexpr.cpp:30
+/*
+// TODO: Add support for [[msvc::constexpr]] constructor
+struct S2 {
----------------
I see this is still TODO, part of the reason I have been putting off review, I
thought this patch wasn't ready for review. Whats going on here? When is this
intended to be implemented?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134475/new/
https://reviews.llvm.org/D134475
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
