RIscRIpt marked an inline comment as done.
RIscRIpt added a comment.
In D134475#4655389 <https://reviews.llvm.org/D134475#4655389>, @erichkeane
wrote:
> If you can properly rebase, submit this to github, and include a summary of
> the Phab discussion in a way that easy enough to catch back up on, I'll do a
> deep dive into this in the next week or 3.
> Sorry for the delay, this fell off my radar somehow.
Sure, I'll try to write a summary of comments, and submit it to GitHub.
No problems regarding delays, I couldn't work at this patch in the beginning of
this year, so it was delayed for so long.
================
Comment at: clang/test/SemaCXX/ms-constexpr.cpp:30
+/*
+// TODO: Add support for [[msvc::constexpr]] constructor
+struct S2 {
----------------
erichkeane wrote:
> I see this is still TODO, part of the reason I have been putting off review,
> I thought this patch wasn't ready for review. Whats going on here? When is
> this intended to be implemented?
Unfortunately, I don't think it's feasible with reasonable changes. I explained
it in comment https://reviews.llvm.org/D134475#4288759 - search for "literal
type".
Basically, support of `[[msvc::constexpr]]` constructors is not needed to be
able to compile code from Microsoft's C++ Standard Library.
I think, I could create a follow up issue on GitHub, and make a reference to
the issue here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134475/new/
https://reviews.llvm.org/D134475
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
