smeenai added inline comments.
================ Comment at: lib/Sema/SemaTemplate.cpp:7670-7673 + if ((Old_TSK == TSK_ExplicitInstantiationDeclaration || + Old_TSK == TSK_ImplicitInstantiation) && (TSK == TSK_ExplicitInstantiationDefinition || DLLImportExplicitInstantiationDef)) { ---------------- rnk wrote: > Is this the right logic in the case of `Old_TSK == TSK_Implicit && TSK == > TSK_Explicit`? We don't want a behavior change when DLLImport is not > involved. A test for that case would be good. I'm actually concerned about the `dllexport` case and not the `dllimport` case, after my discussion with @hans. I'm updating this diff to that effect. https://reviews.llvm.org/D26657 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits