================
@@ -2177,7 +2177,8 @@ struct CounterCoverageMappingBuilder
}
void VisitOpaqueValueExpr(const OpaqueValueExpr* OVE) {
- Visit(OVE->getSourceExpr());
+ if (const Expr *SE = OVE->getSourceExpr())
----------------
efriedma-quic wrote:
If you have a BinaryConditionalOperator, I'm not sure this does the right
thing. If I'm following correctly, you end up visiting the condition twice,
which is not accurately reflecting the way this actually executes. The correct
way to visit a BinaryConditionalOperator is to visit the "common" expression
(BinaryConditionalOperator::getCommon()) first, then don't recurse into the
OpaqueValueExpr.
https://github.com/llvm/llvm-project/pull/85837
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
