================
@@ -2177,7 +2177,8 @@ struct CounterCoverageMappingBuilder
}
void VisitOpaqueValueExpr(const OpaqueValueExpr* OVE) {
- Visit(OVE->getSourceExpr());
+ if (const Expr *SE = OVE->getSourceExpr())
----------------
bolshakov-a wrote:
> If I'm following correctly, you end up visiting the condition twice
No, the "true" branch visitation (`propagateCounts`) is performed only when it
is the ordinary `ConditionalOperator`
(https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/CoverageMappingGen.cpp#L2018).
Do you think it should be rewritten first? It's just the first case found by me
where a non-unique OVE has a source expression which is visited. There may be
more cases.
https://github.com/llvm/llvm-project/pull/85837
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
