Troy-Butler wrote:

> @Troy-Butler I started to do the merge, but I cancelled it for now because it 
> seems that github mangles the email metadata: 
> ![image](https://private-user-images.githubusercontent.com/43410265/325606235-d783c97f-f5f7-469f-9f77-9689275ea429.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTQwNDk5ODMsIm5iZiI6MTcxNDA0OTY4MywicGF0aCI6Ii80MzQxMDI2NS8zMjU2MDYyMzUtZDc4M2M5N2YtZjVmNy00NjlmLTlmNzctOTY4OTI3NWVhNDI5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDI1VDEyNTQ0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI4Zjk0YmRlNzhmM2U3YzhkMzdjOTYwMzRlNTkzNzFjNWFjMDY4NzNlNTU4MTQxOTIzMDBjMDNmNjk2NTRhMDEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.zJuB-MK7hKiN7DwagaI-3SEWA5q5MoVMJYY88Ss4ckU)
>  (Note that I obscured your email address in this screenshot, but it can be 
> found within the commits that you published.)
> 
> * I'd guess that want to use your "real" email address as the Author of this 
> commit -- that case you probably need to change your github account settings. 
> (I don't know the exact details but IIRC you can toggle whether it will use 
> your email address in your commits.) Ping me when you're ready and I'll check 
> the merge again.
> * If you don't want to embed that email address into the LLVM git history, 
> then I can merge the commit without the `Signed-off-by` and `Co-authored-by` 
> lines that mention it. The address will remain on the internet (in this pull 
> request), but it won't be part of the LLVM main branch.

Thank you for pointing that out. I don't have any issues with that email 
address being embedded in LLVM's git history - you can  go ahead and commit. 
Thanks!

https://github.com/llvm/llvm-project/pull/89512
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to