https://github.com/JonChesterfield requested changes to this pull request.

The amdgpu patch is incorrect, see 
https://github.com/llvm/llvm-project/pull/96370/

The nvptx lowering looks dubious - values smaller than slot size should be 
passed with the same alignment as the slot and presently aren't. A struct 
containing i8, i16 or half should be miscompiled on nvptx as written.

No comment on the libc part.

https://github.com/llvm/llvm-project/pull/96369
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to