rnk added inline comments.
================ Comment at: lib/Driver/MSVCToolChain.cpp:34 + #if 0 + #define USE_VS_SETUP_CONFIG + #endif ---------------- What are the outstanding issues preventing you from enabling this by default? ================ Comment at: lib/Driver/MSVCToolChain.cpp:160 + + NotAToolChain: + ; ---------------- I think it would be clearer if you separated out the PATH search into a separate helper. ================ Comment at: lib/Driver/MSVCToolChain.cpp:263 + +ConfigQueryUnsuccessful: + ; ---------------- Similarly, I think this should be a separate helper. It wouldn't need goto. https://reviews.llvm.org/D28365 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
