mydeveloperday wrote: > > I'd personally like a solution that doesn't remove the > > ClangFormatStyleOptions.rst from the review > > Could we just test that the output looks as expected? I think it would be > pretty easy to write a lit test that asserts all of the output is as > expected. That would then show up in review. > > It would be a bit of a hack, but it would solve the original problem, making > sure that the docs actually get updated with the script automatically, and > that things show up in review.
As a reviewer that means we have to download the review, rebuild the rst then check it. I don't quite understand the problem we are trying to solve here? Given that the python script unpacks the Format.h and makes the rst I would prefer to see the finished rst as part of the review. Sorry this doesn't fit your agenda but your not the one doing the reviews! https://github.com/llvm/llvm-project/pull/113739 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
