carlocab wrote:

> Need to add test. You should add `CLANG_USE_XCSELECT` as a requirement and 
> label all the tests properly (including those will break). Maybe you can also 
> remove the hack for `CLANG_NO_XCSELECT` but I am neutral on that.

All done, thanks.

I don't quite understand why the failing tests are caused to fail when 
`CLANG_USE_XCSELECT` is enabled. I'll have to put more time into investigating 
them -- I consider this another blocker for enabling this feature more widely.

https://github.com/llvm/llvm-project/pull/119670
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to