carlocab wrote:

> > I don't quite understand why the failing tests are caused to fail when 
> > `CLANG_USE_XCSELECT` is enabled. I'll have to put more time into 
> > investigating them -- I consider this another blocker for enabling this 
> > feature more widely.
> 
> I think the issue is that the implicit `-isysroot` flag from `libxcselect` 
> changes the deployment target, which then also changes the behaviour of 
> `clang` in these tests. But I'll need to verify this locally to make sure.

Yea, this seems right. Adding appropriate `-mmacosx-version-min=` flags to the 
failing tests seems to make them succeed again. Not sure if that's the right 
move, though.

https://github.com/llvm/llvm-project/pull/119670
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to