pirama marked an inline comment as done. pirama added inline comments.
================ Comment at: lib/Driver/Tools.cpp:2007-2009 + // In the cross-compilation case, arch-specific library path is likely + // unavailable at runtime. + if (TC.isCrossCompiling()) return; ---------------- rnk wrote: > This seems like a really poor heuristic for "will the user ship this binary > to another computer that doesn't have clang installed in the same location", > but the convenience of not having to add clang's unpredictably named resource > library directory to LD_LIBRARY_PATH seems worth baking in a possibly-wrong > rpath. This is indeed poor, but a good check that omits rpath when it is definitely useless but leave it in case it might be useful. https://reviews.llvm.org/D30015 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
