shafik wrote:

> > I see a lot of diagnostics were updated to `DefaultError` but I don't see 
> > matching tests that demonstrate the now error. We should be testing each 
> > diagnostic.
> 
> #123464 also added `-Werror=return-type` to some tests; we can remove those 
> now, which should cover at least some of the diagonstics; I’ll add a test for 
> whatever is left after that because I don’t think we have one for e.g. the 
> coroutine ones.

I missed that but it was a large change.

In the future it would be helpful to mention that in the summary since we do 
expect all diagnostics we modify/add to have full coverage. Otherwise we leave 
ourselves open to future regressions. 

https://github.com/llvm/llvm-project/pull/123470
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to