klimek added a comment. In https://reviews.llvm.org/D34304#784496, @saugustine wrote:
> In https://reviews.llvm.org/D34304#783675, @klimek wrote: > > > I think a better way might be to generally leave dependency options alone, > > add a default argument adapter to filter out all deps related flags, and > > allow users to add their own argument adapters that don't do that. > > > This argument adapter would have to be passed down in a similar way, no? > > buildASTFromCodeWithArgs, toolIinvocation::Run, and newInvocation are all > entry-points that would need this behavior, and all are called by themselves > in one place or another. I think it's cleaner, because it uses a concept we already have (argument adapters). > I'm happy to do that, as it is quite a bit more flexible, but it doesn't seem > any cleaner. https://reviews.llvm.org/D34304 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
