saugustine added a comment.

In https://reviews.llvm.org/D34304#787699, @klimek wrote:

> I mean, arguments need to be adjusted before converting to ArgStringList and 
> calling newInvocation? I'm not sure I fully understand the problem, can you 
> elaborate?


This gets back to why the original patch plumbed the boolean all the way down 
to newInvocation.

newInvocation is the function that actually discards the dependency file 
options--today unconditionally. But there is code that calls newInvocation 
directly (ClangFuzzer is one), without going through a higher-level API. So I 
can't adjust the arguments at a higher level and still preserve the old 
behavior.

Unfortunately, newInvocation's argument list type is incompatible with 
ArgumentAdjusters, so something else will need to be done. What do you 
recommend?


https://reviews.llvm.org/D34304



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to