dcoughlin added inline comments.
================
Comment at: lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp:3412
+ if (FD->getDefinition()) {
+ canEval = hasRCAnnotation(FD->getDefinition(),
+ "rc_ownership_trusted_implementation");
----------------
I'd like you to keep a call to "isTrustedReferenceCountImplementation()". The
name of the function indicates what it means (rather than how it does it),
which will be important when/if we change how annotations are implemented (for
example, away from using the 'annotation' attribute to a custom attribute).
Using common code to check for annotations makes a lot sense though -- can you
call hasRCAnnotation() from inside isTrustedReferenceCountImplementation()?
Repository:
rL LLVM
https://reviews.llvm.org/D34937
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
