dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land.
LGTM! One thing I should have noted in a prior review is that the helper functions should be declared 'static' so that we don't have a public symbol for them. Making them static will prevent a linker error if some other part of clang declares a function with the same signature. This is unlikely, but we try to keep things clean. I will update the two functions to be static and commit. Repository: rL LLVM https://reviews.llvm.org/D34937 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
