hax0kartik wrote: > > > Can you add the reproducer from the issue as a test case as well? > > > Otherwise, this lgtm. > > > > > > Thanks for the quick review! The testcase in that issue only works when > > `-std=c++03` or lower is passed and IMHO, isn't a good representation of > > the actual issue at hand. Do you still want me to add it? > > Yes, it should be added regardless to demonstrate that this patch actually > fixes that issue; if it requires C++98 you’ll also have to put it in a > separate file
Added, please check again. Thanks! https://github.com/llvm/llvm-project/pull/174603 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
